[PATCH 2/2] nanddump: add --nobad to read bad blocks

Wolfram Sang w.sang at pengutronix.de
Mon Sep 13 02:22:09 EDT 2010


On Mon, Sep 13, 2010 at 06:50:04AM +0100, Jon Povey wrote:
> Mike Frysinger wrote:
> > Sometimes dumping bad blocks is useful, like when the data isn't actually
> > bad but the OOB layout isn't what the kernel is expecting or is otherwise
> > screwed up.  The --nobad option allows just that.
> 
> > +"-N         --nobad              Read without bad block skipping\n"
> 
> This doesn't seem like a good name for the option to me. A useful option but
> an unintuitive name, "nobad" sounds like it is going to omit bad blocks,
> where actually it is going to include them.
> 
> "noskipbad" or "includebad" would seem to be better.

I agree. Is that still fixable despite being pushed already?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20100913/85cd0acc/attachment.sig>


More information about the linux-mtd mailing list