[PATCH] nanddump: Rename --nobad to --noskipbad
Wolfram Sang
w.sang at pengutronix.de
Mon Sep 13 03:15:13 EDT 2010
"nobad" might lead to the assumption that bad blocks are skipped, but this
option does exactly the opposite. Use a more descriptive name.
Reported-by: Jon Povey <Jon.Povey at racelogic.co.uk>
Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
Cc: Mike Frysinger <vapier at gentoo.org>
---
Build tested only.
nanddump.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/nanddump.c b/nanddump.c
index 8b3d4a1..709b2db 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -50,7 +50,7 @@ static void display_help (void)
"-f file --file=file Dump to file\n"
"-l length --length=length Length\n"
"-n --noecc Read without error correction\n"
-"-N --nobad Read without bad block skipping\n"
+"-N --noskipbad Read without bad block skipping\n"
"-o --omitoob Omit oob data\n"
"-b --omitbad Omit bad blocks from the dump\n"
"-p --prettyprint Print nice (hexdump)\n"
@@ -77,7 +77,7 @@ static void display_version (void)
static bool pretty_print = false; // print nice
static bool noecc = false; // don't error correct
-static bool nobad = false; // don't skip bad blocks
+static bool noskipbad = false; // don't skip bad blocks
static bool omitoob = false; // omit oob data
static unsigned long start_addr; // start address
static unsigned long length; // dump length
@@ -107,7 +107,7 @@ static void process_options (int argc, char * const argv[])
{"startaddress", required_argument, 0, 's'},
{"length", required_argument, 0, 'l'},
{"noecc", no_argument, 0, 'n'},
- {"nobad", no_argument, 0, 'N'},
+ {"noskipbad", no_argument, 0, 'N'},
{"quiet", no_argument, 0, 'q'},
{0, 0, 0, 0},
};
@@ -162,7 +162,7 @@ static void process_options (int argc, char * const argv[])
noecc = true;
break;
case 'N':
- nobad = true;
+ noskipbad = true;
break;
case '?':
error++;
@@ -396,7 +396,7 @@ int main(int argc, char * const argv[])
for (ofs = start_addr; ofs < end_addr ; ofs+=bs) {
// new eraseblock , check for bad block
- if (nobad) {
+ if (noskipbad) {
badblock = 0;
} else if (blockstart != (ofs & (~meminfo.erasesize + 1))) {
blockstart = ofs & (~meminfo.erasesize + 1);
--
1.7.1
More information about the linux-mtd
mailing list