[PATCH] NAND: nandsim bad block injection

[Artem Bityutskiy]

Vijay,

On Wed, 2006-12-27 at 20:54 +0530, Vijay Kumar wrote:
> Adds support for bad block creation on block erase and page program,
> by returning erase/program failed in the status byte. The probability
> of fault occurrence can be specified through module parameters.

the patch looks fine, and it is useful for debugging. But I have few
concerns.

1. Suppose we decided to emulate an erase failure for a certain
eraseblock. Then the MTD user re-tries the operation and succeeds.
Shouldn't we start always returning erase errors for this eraseblock
instead?

2. In case of I/O errors, the correct MTD user should mark the bogus
eraseblock bad. So, after some time we end up with most of our
eraseblocks marked bad which is not very nice.

How would you comment this?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)