[PATCH RFC net-next v2 0/5] net: dsa: always use phylink

Florian Fainelli f.fainelli at gmail.com
Wed Jul 6 09:27:20 PDT 2022


On 7/6/22 03:14, Vladimir Oltean wrote:
> Hi Florian,
> 
> On Tue, Jul 05, 2022 at 09:42:33AM -0700, Florian Fainelli wrote:
>> On 7/5/22 02:46, Russell King (Oracle) wrote:
>>> A new revision of the series which incorporates changes that Marek
>>> suggested. Specifically, the changes are:
>>>
>>> 1. Patch 2 - use the phylink_get_caps method in mv88e6xxx to get the
>>>      default interface rather than re-using port_max_speed_mode()
>>>
>>> 2. Patch 4 - if no default interface is provided, use the supported
>>>      interface mask to search for the first interface that gives the
>>>      fastest speed.
>>>
>>> 3. Patch 5 - now also removes the port_max_speed_mode() method
>>
>> This was tested with bcm_sf2.c and b53_srab.b and did not cause regressions,
>> however we do have a 'fixed-link' property for the CPU port (always have had
>> one), so there was no regression expected.
> 
> What about arch/arm/boot/dts/bcm47189-tenda-ac9.dts?

You found one of the devices that I do not have access to and did not 
test, thanks. We do expect to run the port at 2GBits/sec on these 
devices however there is no "official" way to advertise that a port can 
run at 2Gbits/sec, as this is not even a "sanctioned" speed. I do have a 
similar device however, so let me run some more tests, we won't see a 
regression however since we do not use the NATP accelerator which would 
be the reason to run the port at 2Gbits/sec.
-- 
Florian



More information about the Linux-mediatek mailing list