[PATCH RFC net-next v2 0/5] net: dsa: always use phylink
Vladimir Oltean
olteanv at gmail.com
Wed Jul 6 03:14:59 PDT 2022
Hi Florian,
On Tue, Jul 05, 2022 at 09:42:33AM -0700, Florian Fainelli wrote:
> On 7/5/22 02:46, Russell King (Oracle) wrote:
> > A new revision of the series which incorporates changes that Marek
> > suggested. Specifically, the changes are:
> >
> > 1. Patch 2 - use the phylink_get_caps method in mv88e6xxx to get the
> > default interface rather than re-using port_max_speed_mode()
> >
> > 2. Patch 4 - if no default interface is provided, use the supported
> > interface mask to search for the first interface that gives the
> > fastest speed.
> >
> > 3. Patch 5 - now also removes the port_max_speed_mode() method
>
> This was tested with bcm_sf2.c and b53_srab.b and did not cause regressions,
> however we do have a 'fixed-link' property for the CPU port (always have had
> one), so there was no regression expected.
What about arch/arm/boot/dts/bcm47189-tenda-ac9.dts?
Just to make sure I'm simply not seeing something, I compiled and then
decompiled the dtb. We have:
ethernet at 5000 {
reg = <0x5000 0x1000>;
phandle = <0x03>;
mdio {
#address-cells = <0x01>;
#size-cells = <0x00>;
switch at 1e {
compatible = "brcm,bcm53125";
reg = <0x1e>;
status = "okay";
ports {
#address-cells = <0x01>;
#size-cells = <0x00>;
port at 0 {
reg = <0x00>;
label = "wan";
};
port at 1 {
reg = <0x01>;
label = "lan1";
};
port at 2 {
reg = <0x02>;
label = "lan2";
};
port at 3 {
reg = <0x03>;
label = "lan3";
};
port at 4 {
reg = <0x04>;
label = "lan4";
};
port at 5 {
reg = <0x05>;
label = "cpu";
ethernet = <0x03>; <- CPU port with no phy-handle, no fixed-link
};
};
};
};
};
More information about the Linux-mediatek
mailing list