[PATCH can] can: sun4i_can: sun4i_can_interrupt(): fix max irq loop handling
Jernej Škrabec
jernej.skrabec at gmail.com
Sun Nov 16 08:20:37 PST 2025
Dne nedelja, 16. november 2025 ob 16:55:26 Srednjeevropski standardni čas je Marc Kleine-Budde napisal(a):
> Reading the interrupt register `SUN4I_REG_INT_ADDR` causes all of its bits
> to be reset. If we ever reach the condition of handling more than
> `SUN4I_CAN_MAX_IRQ` IRQs, we will have read the register and reset all its
> bits but without actually handling the interrupt inside of the loop body.
>
> This may, among other issues, cause us to never `netif_wake_queue()` again
> after a transmission interrupt.
>
> Fixes: 0738eff14d81 ("can: Allwinner A10/A20 CAN Controller support - Kernel module")
> Cc: stable at vger.kernel.org
> Co-developed-by: Thomas Mühlbacher <tmuehlbacher at posteo.net>
> Signed-off-by: Thomas Mühlbacher <tmuehlbacher at posteo.net>
> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> ---
> I've ported the fix from the sja1000 driver to the sun4i_can, which based
> on the sja1000 driver.
Acked-by: Jernej Skrabec <jernej.skrabec at gmail.com>
Best regards,
Jernej
More information about the linux-arm-kernel
mailing list