RE: [PATCH 1/3] dt-bindings: can: xilinx_can: Add ECC property ‘xlnx,has-ecc’

[Goud, Srinivas]

Hi

>-----Original Message-----
>From: Krzysztof Kozlowski <krzk at kernel.org>
>Sent: Wednesday, June 14, 2023 4:41 PM
>To: Goud, Srinivas <srinivas.goud at amd.com>; Marc Kleine-Budde
><mkl at pengutronix.de>
>Cc: wg at grandegger.com; davem at davemloft.net; edumazet at google.com;
>kuba at kernel.org; pabeni at redhat.com; gcnu.goud at gmail.com; git (AMD-
>Xilinx) <git at amd.com>; michal.simek at xilinx.com; linux-can at vger.kernel.org;
>linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
>Subject: Re: [PATCH 1/3] dt-bindings: can: xilinx_can: Add ECC property
>‘xlnx,has-ecc’
>
>On 14/06/2023 12:22, Goud, Srinivas wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Marc Kleine-Budde <mkl at pengutronix.de>
>>> Sent: Tuesday, June 13, 2023 1:23 PM
>>> To: Goud, Srinivas <srinivas.goud at amd.com>
>>> Cc: wg at grandegger.com; davem at davemloft.net; edumazet at google.com;
>>> kuba at kernel.org; pabeni at redhat.com; gcnu.goud at gmail.com; git (AMD-
>>> Xilinx) <git at amd.com>; michal.simek at xilinx.com;
>>> linux-can at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
>>> linux-kernel at vger.kernel.org
>>> Subject: Re: [PATCH 1/3] dt-bindings: can: xilinx_can: Add ECC
>>> property ‘xlnx,has-ecc’
>>>
>>> On 12.06.2023 17:12:55, Srinivas Goud wrote:
>>>> ECC feature added to Tx and Rx FIFO’s for Xilinx CAN Controller.
>>>> Part of this feature configuration and counter registers added in IP
>>>> for 1bit/2bit ECC errors.
>>>> Please find more details in PG096 v5.1 document.
>>>>
>>>> xlnx,has-ecc is optional property and added to Xilinx CAN Controller
>>>> node if ECC block enabled in the HW.
>>>>
>>>> Signed-off-by: Srinivas Goud <srinivas.goud at amd.com>
>>>
>>> Is there a way to introspect the IP core to check if this feature is compiled in?
>> There is no way(IP registers) to indicate whether ECC feature is enabled or
>not.
>
>Isn't this then deductible from compatible? Your binding claims it is only for
>AXI CAN, so xlnx,axi-can-1.00.a, even though you did not restrict it in the
>binding.
Agree it is only for AXI CAN(xlnx,axi-can-1.00.a) but ECC feature is
configurable option to the user.
ECC is added as optional configuration(enable/disable) feature 
to the existing AXI CAN.

Thanks,
Srinivas