[PATCH] soc: ti: pm33xx: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

Nishanth Menon nm at ti.com
Fri Apr 22 11:40:21 PDT 2022


On 06:30-20220418, cgel.zte at gmail.com wrote:
> From: Minghao Chi <chi.minghao at zte.com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao at zte.com.cn>

Tony: Could you check?

> ---
>  drivers/soc/ti/pm33xx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c
> index 7bab4bbaf02d..ce09c42eaed2 100644
> --- a/drivers/soc/ti/pm33xx.c
> +++ b/drivers/soc/ti/pm33xx.c
> @@ -555,11 +555,9 @@ static int am33xx_pm_probe(struct platform_device *pdev)
>  #endif /* CONFIG_SUSPEND */
>  
>  	pm_runtime_enable(dev);
> -	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret < 0)
>  		goto err_pm_runtime_disable;
> -	}
>  
>  	ret = pm_ops->init(am33xx_do_sram_idle);
>  	if (ret) {
> -- 
> 2.25.1
> 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D



More information about the linux-arm-kernel mailing list