[PATCH] ARM: dts: imx6sx: Fix LCDIF interrupt type

[Marek Vasut]

On 10/02/2016 07:43 PM, Fabio Estevam wrote:
> Hi Marek,

Hi!

> On Sun, Oct 2, 2016 at 1:44 PM, Marek Vasut <marex at denx.de> wrote:
>> The LCDIF interrupt should be triggered by the rising edge of the
>> IRQ line because we only want the interrupt to trigger once per each
>> frame. It seems the LCDIF IRQ line cannot be explicitly de-asserted
>> by software, so the previous behavior before this patch, where the
>> interrupt was triggered by level-high status of the IRQ line, caused
>> the interrupt to fire again immediatelly after it was handled, which
>> caused the system to lock up due to the high rate of interrupts.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Lucas Stach <l.stach at pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>> Cc: Shawn Guo <shawnguo at kernel.org>
>> ---
>>  arch/arm/boot/dts/imx6sx.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
>> index 1a473e8..9526c38 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -1143,7 +1143,7 @@
>>                                 lcdif1: lcdif at 02220000 {
>>                                         compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>>                                         reg = <0x02220000 0x4000>;
>> -                                       interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>> +                                       interrupts = <GIC_SPI 5 IRQ_TYPE_EDGE_RISING>;
> 
> What about mx6ul and mx6sl.dtsi? Shouldn't they be also updated?

Probably, but I don't have the hardware to test MXSFB DRM/KMS driver on
those. I can mail you the necessary patches if you want to try it out,
the latest version is not in the ML yet as there is some DRM
infrastructure work going on.

-- 
Best regards,
Marek Vasut