[PATCH] ARM: dts: imx6sx: Fix LCDIF interrupt type

Lucas Stach l.stach at pengutronix.de
Mon Oct 10 06:35:56 PDT 2016


Am Sonntag, den 02.10.2016, 18:44 +0200 schrieb Marek Vasut:
> The LCDIF interrupt should be triggered by the rising edge of the
> IRQ line because we only want the interrupt to trigger once per each
> frame. It seems the LCDIF IRQ line cannot be explicitly de-asserted
> by software, so the previous behavior before this patch, where the
> interrupt was triggered by level-high status of the IRQ line, caused
> the interrupt to fire again immediatelly after it was handled, which
> caused the system to lock up due to the high rate of interrupts.
> 
If there is no way to ack the IRQ how is the line going low again? Some
hardware state machine?

> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam at nxp.com>
> Cc: Shawn Guo <shawnguo at kernel.org>
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 1a473e8..9526c38 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1143,7 +1143,7 @@
>  				lcdif1: lcdif at 02220000 {
>  					compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>  					reg = <0x02220000 0x4000>;
> -					interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> +					interrupts = <GIC_SPI 5 IRQ_TYPE_EDGE_RISING>;
>  					clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
>  						 <&clks IMX6SX_CLK_LCDIF_APB>,
>  						 <&clks IMX6SX_CLK_DISPLAY_AXI>;
> @@ -1154,7 +1154,7 @@
>  				lcdif2: lcdif at 02224000 {
>  					compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>  					reg = <0x02224000 0x4000>;
> -					interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> +					interrupts = <GIC_SPI 6 IRQ_TYPE_EDGE_RISING>;
>  					clocks = <&clks IMX6SX_CLK_LCDIF2_PIX>,
>  						 <&clks IMX6SX_CLK_LCDIF_APB>,
>  						 <&clks IMX6SX_CLK_DISPLAY_AXI>;





More information about the linux-arm-kernel mailing list