[PATCH V2 3/4] ARM: dts: imx6ul: Add GPMI nand controller support

[Lothar Waßmann]

Hi,

On Sun, 20 Mar 2016 09:44:19 +0100 Michael Trimarchi wrote:
> Hi Lothar
> 
> On Mon, Feb 22, 2016 at 9:26 AM, Lothar Waßmann <LW at karo-electronics.de> wrote:
> > Hi,
> >
> > On Sun, 21 Feb 2016 12:29:53 +0100 Michael Trimarchi wrote:
> >> Add support for GPMI nand controller.
> >>
> >> Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> >> ---
> >> Changes V2:
> >>       - drop special IMXUL type because seems that is compatible
> >>         with IMX6Q
> >>
> >>  arch/arm/boot/dts/imx6ul.dtsi | 33 +++++++++++++++++++++++++++++++++
> >>  1 file changed, 33 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> >> index f4daf97..1a486ac 100644
> >> --- a/arch/arm/boot/dts/imx6ul.dtsi
> >> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> >> @@ -142,6 +142,39 @@
> >>                       reg = <0x00900000 0x20000>;
> >>               };
> >>
> >> +             dma_apbh: dma-apbh at 01804000 {
> >> +                     compatible = "fsl,imx6ul-dma-apbh", "fsl,imx28-dma-apbh";
> >> +                     reg = <0x01804000 0x2000>;
> >> +                     interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
> >> +                                  <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
> >> +                                  <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
> >> +                                  <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
> >> +                     interrupt-names = "gpmi0", "gpmi1", "gpmi2", "gpmi3";
> >> +                     #dma-cells = <1>;
> >> +                     dma-channels = <4>;
> >> +                     clocks = <&clks IMX6UL_CLK_APBHDMA>;
> >> +             };
> >> +
> >> +             gpmi: gpmi-nand at 01806000 {
> >> +                     compatible = "fsl,imx6q-gpmi-nand";
> >>
> > You should still add an imx6ul specific compatible (likewise to the
> > dma_apbh).
> >
> 
> I understand your point but this seems that imx6q and imx6sx are
> defined in the same way
> 
That doesn't mean they are correct. I got the same comment from Lucas
Stach in <1452678036.3694.51.camel at pengutronix.de>


Lothar Waßmann