[PATCH 2/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Apr 14 07:26:51 PDT 2016


Hello,

On Mon, 28 Mar 2016 23:21:57 +0200, Arnd Bergmann wrote:
> On Sunday 27 March 2016 11:30:58 Thomas Petazzoni wrote:
> > +       /* Wait until the link becomes active again */
> > +       while (timeout) {
> > +               if (armada8k_pcie_link_up(pp))
> > +                       break;
> > +               udelay(1);
> > +               timeout--;
> > +       }
> > 
> 
> Why the busy-loop here?
> 
> Maybe just do a single msleep(1) here to wait for the link to
> come up instead?

I've changed the udelay(1) by msleep(1). Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list