[PATCH v2 17/38] ARM: orion5x: use node labels for UART and SATA on edmini_v2

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Wed Apr 23 05:46:26 PDT 2014


On Apr 23, Thomas Petazzoni wrote:
> I continue to have mixed feelings about the usage of node labels. To
> me, it breaks the "tree" nature of the Device Tree, by turning it into
> just a bunch of &bleh { ... } long list of statements. But this is
> purely subjective (just like your opinion, I believe), and I wanted to
> move forward with this, so I just did what was necessary :-)

Let me try to convince you a little :) Regressions like this would never
appear with proper usage of phandles:


This may be a matter of taste, but when I'm on the devicetree "user" side,
I really don't care if the USB0 is part of some super complex tree, but just
want to enable it in my board. Writing:

&usb0 {
	status = "okay";

seems to be just fine.
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering

More information about the linux-arm-kernel mailing list