[PATCH v2 17/38] ARM: orion5x: use node labels for UART and SATA on edmini_v2

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 23 05:23:34 PDT 2014


Dear Sebastian Hesselbarth,

On Wed, 23 Apr 2014 13:23:38 +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 11:26 PM, Thomas Petazzoni wrote:
> > This commit converts the existing devices described in the edmini_v2
> > Device Tree to use node labels: the UART and SATA device. Also, it
> > reorders the eth and mdio node label references to be sorted
> > alphabetically.
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> 
> Does this also mean, we agree on the "using node label references" topic
> for Kirkwood?

Well, for Kirkwood I don't know, I'm not the one who has done most of
the Kirkwood conversions.

I continue to have mixed feelings about the usage of node labels. To
me, it breaks the "tree" nature of the Device Tree, by turning it into
just a bunch of &bleh { ... } long list of statements. But this is
purely subjective (just like your opinion, I believe), and I wanted to
move forward with this, so I just did what was necessary :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list