[PATCH] ARM: imx6: clk: i.MX6 DualLite/Solo i2c4 clock
Iain Paton
ipaton0 at gmail.com
Fri Apr 18 06:25:52 PDT 2014
On 17/04/14 14:00, Shawn Guo wrote:
> On Thu, Apr 17, 2014 at 03:41:11PM +0300, Vladimir Zapolskiy wrote:
>> On 04/16/14 21:33, Iain Paton wrote:
>>> - clk[ecspi5] = imx_clk_gate2("ecspi5", "ecspi_root", base + 0x6c, 8);
>>> + if (cpu_is_imx6dl())
>>> + /*
>>> + * ecspi5 is replaced with i2c4 on imx6dl& imx6s
>>> + */
>>> + clk[ecspi5] = imx_clk_gate2("i2c4", "ipg_per", base + 0x6c, 8);
>>
>> Is it good enough to reuse ecspi5 enum value here or may it be
>> better to introduce a new one i2c4 equal to ecspi5?
>
> With the comment in there, it's just fine to reuse the enum, I think.
I wasn't sure about that, but couldn't find anywhere else the enum was used. In
the dts the clock is simply referenced as <&clks 116> so you have to work that
back manually.
If you think it's worth it to add something to
Documentation/devicetree/bindings/clock/imx6q-clock.txt so that the difference
is documented I can send a patch for that.
Iain
More information about the linux-arm-kernel
mailing list