[PATCH 012/228] cpufreq: sparc: call cpufreq_frequency_table_get_attr()

Viresh Kumar viresh.kumar at linaro.org
Sat Sep 14 00:01:41 EDT 2013


On 14 September 2013 03:17, David Miller <davem at davemloft.net> wrote:
> From: Viresh Kumar <viresh.kumar at linaro.org>
> Date: Fri, 13 Sep 2013 18:29:18 +0530
>
>> This exposes frequency table of driver to cpufreq core and is required for core
>> to guess what the index for a target frequency is, when it calls
>> cpufreq_frequency_table_target(). And so this driver needs to expose it.
>>
>> Cc: David S. Miller <davem at davemloft.net>
>> Cc: sparclinux at vger.kernel.org
>> Signed-off-by: Viresh Kumar <viresh.kumar at linaro.org>
>
> Wait a second, later in this series you add the put_attr() call claiming
> it's a fix.
>
> But you're the one adding the "bug" here.
>
> So if you are going to add a get_attr() call you should be adding the
> necessary put_attr() call in the same patch.  Otherwise this patch
> introduces a bug.

Yeah, my mistake.. It was required to be added at both places for
very few drivers and so made this mistake..

I will merge both of those patches together..



More information about the linux-arm-kernel mailing list