[PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Nov 25 12:09:35 EST 2013
Dear Jason Gunthorpe,
On Thu, 31 Oct 2013 17:32:59 -0600, Jason Gunthorpe wrote:
> When PCI_COMMAND_MEMORY/PCI_COMMAND_IO are cleared the bridge should not
> allocate windows or even look at the window limit/base registers.
>
> Otherwise it can attempt to setup bogus windows that the PCI core code
> creates during discovery. The core will leave PCI_COMMAND_IO cleared if
> it doesn't need an IO window.
>
> Have mvebu_pcie_handle_*_change respect the bits, and call the change
> function whenever the bits changes.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
> ---
> drivers/pci/host/pci-mvebu.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Tested-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list