[PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits

Jason Cooper jason at lakedaemon.net
Mon Nov 25 06:29:51 EST 2013


On Sun, Nov 24, 2013 at 10:52:22PM -0700, Jason Gunthorpe wrote:
> On Sat, Nov 23, 2013 at 09:58:08PM -0500, Jason Cooper wrote:
> > Jason,
> > 
> > On Thu, Oct 31, 2013 at 05:32:59PM -0600, Jason Gunthorpe wrote:
> > > When PCI_COMMAND_MEMORY/PCI_COMMAND_IO are cleared the bridge should not
> > > allocate windows or even look at the window limit/base registers.
> > > 
> > > Otherwise it can attempt to setup bogus windows that the PCI core code
> > > creates during discovery. The core will leave PCI_COMMAND_IO cleared if
> > > it doesn't need an IO window.
> > > 
> > > Have mvebu_pcie_handle_*_change respect the bits, and call the change
> > > function whenever the bits changes.
> > > 
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
> > >  drivers/pci/host/pci-mvebu.c | 14 ++++++++++++--
> > >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > I'd like to get back on track with these small patches being Acked by
> > mvebu maintainers and then going through Bjorn.  Could you please resend
> > an updated patchset for this and 2/2?
> 
> I recall these two patches are waiting for Thomas to give his Ok. His
> testing found problems with the prior versions that I cannot detect on
> my hardware..
> 
> Once that happens I can send them on with his ack to Bjorn?

Please do.

thx,

Jason.



More information about the linux-arm-kernel mailing list