[PATCH] input: sirfsoc_pwrc: add onkey input driver for CSR SiRFprimaII PWRC

Dmitry Torokhov dmitry.torokhov at gmail.com
Thu May 23 12:29:16 EDT 2013


Hi Madhvapathi,

On Thu, May 23, 2013 at 01:49:10PM +0000, Madhvapathi Sriram wrote:
> Possible mem leak here not freeing any allocated devices/memory/irq.
> I suggest all the error handling be collated at the end of this
> function for various stages and error handling be done there.
> Please have a look at
> https://www.kernel.org/doc/Documentation/input/input-programming.txt

Please note that the driver uses managed resources which get cleaned
automatically.

Also, could you please use a sane mailer that wraps long lines properly.

Thanks.

-- 
Dmitry



More information about the linux-arm-kernel mailing list