[PATCH] DMA: PL330: Add check if device tree compatible

Padma Venkat padma.kvr at gmail.com
Tue Mar 5 00:51:46 EST 2013


Hi Arnd,

On Mon, Mar 4, 2013 at 6:28 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 04 March 2013, Padmavathi Venna wrote:
>> +
>> +       if (adev->dev.of_node) {
>> +               ret = of_dma_controller_register(adev->dev.of_node,
>> +                                        of_dma_pl330_xlate, pdmac);
>> +               if (ret) {
>> +                       dev_err(&adev->dev,
>> +                       "unable to register DMA to the generic DT DMA helpers\n");
>> +                       goto probe_err4;
>> +               }
>>         }
>
> Hmm, when I did the same thing in dw_dma, Andy commented that this should
> not be a failure at all, since the device is still usable. Could we
> instead make of_dma_controller_register return silently when it
> gets a NULL of_node?

Ok. I will do that.

Thanks
Padma
>
>         Arnd



More information about the linux-arm-kernel mailing list