[PATCH] DMA: PL330: Add check if device tree compatible

Arnd Bergmann arnd at arndb.de
Mon Mar 4 07:58:38 EST 2013


On Monday 04 March 2013, Padmavathi Venna wrote:
> +
> +       if (adev->dev.of_node) {
> +               ret = of_dma_controller_register(adev->dev.of_node,
> +                                        of_dma_pl330_xlate, pdmac);
> +               if (ret) {
> +                       dev_err(&adev->dev,
> +                       "unable to register DMA to the generic DT DMA helpers\n");
> +                       goto probe_err4;
> +               }
>         }

Hmm, when I did the same thing in dw_dma, Andy commented that this should
not be a failure at all, since the device is still usable. Could we
instead make of_dma_controller_register return silently when it
gets a NULL of_node?

	Arnd



More information about the linux-arm-kernel mailing list