[PATCH 4/4] cpufreq: imx6q: correct VDDSOC/PU voltage scaling when cpufreq is changed
Anson.Huang at freescale.com
Anson.Huang at freescale.com
Tue Dec 17 07:26:12 EST 2013
Sent from Anson's iPhone
> 在 2013年12月17日,20:13,"Shawn Guo" <shawn.guo at linaro.org> 写道:
>
> On Tue, Dec 17, 2013 at 10:53:47AM +0100, Lothar Waßmann wrote:
>>>> + if (soc_opp_index >= soc_opp_count) {
>>>
>>> Can soc_opp_index be possibly greater than soc_opp_count? Otherwise,
>>> the condition check below is good enough?
>>>
>>> if (soc_opp_index == soc_opp_count)
>> it doen't harm to be on the safe side and use >= anyway!
>
> Well, it may confuse reader. At least, it took me some time understand
> how that ">" condition will happen. And it turns out never.
it does not matter now, since in V2 patch, i use index passed from
freq table, no need to look up the soc opp. please help review V2 patch set, thanks.
Anson.
>
> Shawn
>
More information about the linux-arm-kernel
mailing list