[PATCH 4/4] cpufreq: imx6q: correct VDDSOC/PU voltage scaling when cpufreq is changed
Shawn Guo
shawn.guo at linaro.org
Tue Dec 17 07:14:00 EST 2013
On Tue, Dec 17, 2013 at 10:53:47AM +0100, Lothar Waßmann wrote:
> > > + if (soc_opp_index >= soc_opp_count) {
> >
> > Can soc_opp_index be possibly greater than soc_opp_count? Otherwise,
> > the condition check below is good enough?
> >
> > if (soc_opp_index == soc_opp_count)
> >
> it doen't harm to be on the safe side and use >= anyway!
Well, it may confuse reader. At least, it took me some time understand
how that ">" condition will happen. And it turns out never.
Shawn
More information about the linux-arm-kernel
mailing list