Build warning in drivers/dma/mmp_tdma.c

Dan Williams dan.j.williams at intel.com
Tue Dec 3 21:15:37 EST 2013


On Tue, Dec 3, 2013 at 5:58 PM, Qiao Zhou <zhouqiao at marvell.com> wrote:
> On 12/04/2013 09:32 AM, Dan Williams wrote:
>>
>> Please read the question, you can refer to of_get_named_gen_pool() for
>> why I have a question.  Something in the system needs to do the
>> devm_gen_pool_create() for that device.  If you are removing the mmp2
>> sram driver are you switching to the generic sram driver?  If so
>> shouldn't you ensure it is built? Otherwise this will always fail:
>
> For CPU_MMP2 specifically, it switches to use generic sram driver. But
> generally it may not use sram only, a DDR buffer(or other buffer) may also
> be a pool. So here we don't add "select SRAM" directly. In this case we need
> to enable CONFIG_SRAM in mmp2_defconfig.
>
> If no sram or other similar drivers are enabled, it will throw an error for
> warning.
>

Ok, So, please turn this into a compile time dependency (depends on
(SRAM || MMP_SRAM)) so that someone does not need to boot a platform
to figure out they forgot to enable a driver.



More information about the linux-arm-kernel mailing list