[PATCH 05/11] serial: support for 16550 serial ports on LP-8x4x
Sergei Ianovich
ynvich at gmail.com
Mon Dec 2 06:39:26 EST 2013
On Mon, 2013-12-02 at 11:30 +0000, Russell King - ARM Linux wrote:
> On Sun, Dec 01, 2013 at 10:26:18AM +0400, Sergei Ianovich wrote:
> > +static struct platform_device lp8x4x_device = {
> > + .name = "serial8250",
> > + .id = PLAT8250_DEV_ACCENT,
>
> You should not re-use the enum value here. The enum is designed as a
> method to provide the platform devices with a unique id, not as a means
> to identify the manufacturer or anything else like that.
Should I add a new enum?
Or should I use zero?
More information about the linux-arm-kernel
mailing list