[PATCH 05/11] serial: support for 16550 serial ports on LP-8x4x

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Dec 2 06:30:53 EST 2013

On Sun, Dec 01, 2013 at 10:26:18AM +0400, Sergei Ianovich wrote:
> +static struct platform_device lp8x4x_device = {
> +	.name			= "serial8250",
> +	.id			= PLAT8250_DEV_ACCENT,

You should not re-use the enum value here.  The enum is designed as a
method to provide the platform devices with a unique id, not as a means
to identify the manufacturer or anything else like that.

More information about the linux-arm-kernel mailing list