[PATCH 07/12] ARM: move all dtb targets out of Makefile.boot

Stephen Warren swarren at wwwdotorg.org
Tue Sep 11 01:41:37 EDT 2012


On 09/10/2012 10:49 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:51 Mon 10 Sep     , Rob Herring wrote:
>> On 09/10/2012 10:52 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 15:12 Thu 06 Sep     , Rob Herring wrote:
>>>> From: Rob Herring <rob.herring at calxeda.com>
>>>>
>>>> In preparation to support multi-platform kernels, move all the dtb targets
>>>> out of the mach Makefile.boot and into the arch/arm/boot/dts/Makefile
>>>> which is closer to the sources.
>>>>
>>>> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
>>>> Cc: Russell King <linux at arm.linux.org.uk>
>>>> Cc: Andrew Victor <linux at maxim.org.za>
>>>> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
>>>> Cc: Jean-Christophe Plagniol-Villard <plagnioj at jcrosoft.com>
>>>> Cc: Kukjin Kim <kgene.kim at samsung.com>
>>>> Cc: Sascha Hauer <kernel at pengutronix.de>
>>>> Cc: Jason Cooper <jason at lakedaemon.net>
>>>> Cc: Andrew Lunn <andrew at lunn.ch>
>>>> Cc: Gregory Clement <gregory.clement at free-electrons.com>
>>>> Cc: Shawn Guo <shawn.guo at linaro.org>
>>>> Cc: Viresh Kumar <viresh.linux at gmail.com>
>>>> Cc: Shiraz Hashim <shiraz.hashim at st.com>
>>>> Cc: Rajeev Kumar <rajeev-dlh.kumar at st.com>
>>>> Cc: Stephen Warren <swarren at wwwdotorg.org>
>>>> Cc: Srinidhi Kasagar <srinidhi.kasagar at stericsson.com>
>>>> Cc: Linus Walleij <linus.walleij at linaro.org>
>>>> ---
>>>>  arch/arm/boot/Makefile                |    2 ++
>>>>  arch/arm/boot/dts/Makefile            |   41 +++++++++++++++++++++++++++++++++
>>>>  arch/arm/mach-at91/Makefile.boot      |   24 -------------------
>>>>  arch/arm/mach-exynos/Makefile.boot    |    3 ---
>>>>  arch/arm/mach-imx/Makefile.boot       |    7 ------
>>>>  arch/arm/mach-kirkwood/Makefile.boot  |   11 ---------
>>>>  arch/arm/mach-lpc32xx/Makefile.boot   |    2 --
>>>>  arch/arm/mach-mvebu/Makefile.boot     |    2 --
>>>>  arch/arm/mach-mxs/Makefile.boot       |    9 --------
>>>>  arch/arm/mach-spear13xx/Makefile.boot |    3 ---
>>>>  arch/arm/mach-spear3xx/Makefile.boot  |    4 ----
>>>>  arch/arm/mach-spear6xx/Makefile.boot  |    2 --
>>>>  arch/arm/mach-tegra/Makefile.boot     |    8 -------
>>>>  arch/arm/mach-ux500/Makefile.boot     |    2 --
>>>>  arch/arm/mach-vexpress/Makefile.boot  |    5 ----
>>>>  15 files changed, 43 insertions(+), 82 deletions(-)
>>>>  create mode 100644 arch/arm/boot/dts/Makefile
>>>>
>>>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>>>> index c877087..3fdab01 100644
>>>> --- a/arch/arm/boot/Makefile
>>>> +++ b/arch/arm/boot/Makefile
>>>> @@ -15,6 +15,8 @@ ifneq ($(MACHINE),)
>>>>  include $(srctree)/$(MACHINE)/Makefile.boot
>>>>  endif
>>>>  
>>>> +include $(srctree)/arch/arm/boot/dts/Makefile
>>>> +
>>>>  # Note: the following conditions must always be true:
>>>>  #   ZRELADDR == virt_to_phys(PAGE_OFFSET + TEXT_OFFSET)
>>>>  #   PARAMS_PHYS must be within 4MB of ZRELADDR
>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>>> new file mode 100644
>>>> index 0000000..e59586b
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/Makefile
>>>> @@ -0,0 +1,41 @@
>>>> +dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
>>>
>>> sorry I see no need of the dtb-y
>>>
>>> just do all the time
>>
>> That's not how it works today. dtb's only for all enabled platforms are
>> built. Changing the behavior should be a different patch.
>
> no I see no point to check if the platform is enable or not just build all
> 
> This will allow to check them

Why would I want to build 100 .dtbs that I don't care about? If I want
to check them, I can either build all the defconfigs, or simply write a
trivial sh for loop to loop over *.dts in the boot/dts directory.



More information about the linux-arm-kernel mailing list