vexpress issues in next-20121029

Pawel Moll pawel.moll at
Tue Oct 30 12:16:59 EDT 2012

Hi Stephen,

On Mon, 2012-10-29 at 20:24 +0000, Stephen Warren wrote:
> 1) At compile-time: v2m_timer_init() and v2m_dt_timer_init() reference
> functions vexpress_clk_init() and vexpress_clk_of_init() respectively,
> which don't appear anywhere in the source tree.

There was a glitch between clk-next and arm-soc - it should be fine
starting with next-20121030.

> 2) With those calls commented out, I find that
> vexpress_sysreg_init_leds() is device_initcall, and so executes even
> when not running on vexpress HW. This crashes on Tegra (which I have
> converted to single-zImage locally).

Uh, how stupid of me! I have to finally get used to the new
multi-platform-kernel reality... Sorry about it - a quick workaround
would be:

diff --git a/drivers/mfd/vexpress-sysreg.c
index 059d6b1..99e89a8 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -474,7 +474,6 @@ static int __init vexpress_sysreg_init(void)
 #if defined(CONFIG_LEDS_CLASS)
 struct vexpress_sysreg_led {
@@ -526,6 +525,9 @@ static int __init vexpress_sysreg_init_leds(void)
 	struct vexpress_sysreg_led *led;
 	int i;
+	if (!vexpress_sysreg_base)
+		return 0;
 	/* Clear all user LEDs */
 	writel(0, vexpress_sysreg_base + SYS_LED);

while I'm improving the situation by better means.

Sorry about this and thanks for letting me know!


More information about the linux-arm-kernel mailing list