[RFT/PATCH] serial: omap: prevent resume if device is not suspended.
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Oct 12 12:42:02 EDT 2012
On Fri, Oct 12, 2012 at 09:35:54AM -0700, Kevin Hilman wrote:
> Sourav <sourav.poddar at ti.com> writes:
> > diff --git a/drivers/tty/serial/omap-serial.c
> > b/drivers/tty/serial/omap-serial.c
> > index 6ede6fd..3fbc7f7 100644
> > --- a/drivers/tty/serial/omap-serial.c
> > +++ b/drivers/tty/serial/omap-serial.c
> > @@ -1414,6 +1414,7 @@ static int __devinit serial_omap_probe(struct
> > platform_device *pdev)
> > INIT_WORK(&up->qos_work, serial_omap_uart_qos_work);
> > platform_set_drvdata(pdev, up);
> > + pm_runtime_set_active(&pdev->dev);
> This will obviously break platforms where the UARTs are not active
> before driver loads.
I thought I had proposed a solution for this issue, which was this
Yes, I can understand people not liking the omap_device_enable()
there, but I also notice that the email suggesting that never got a
reply either - not even a "I tried this and it doesn't work" or "it
As such, it seems this issue isn't making any progress as we had
already established that merely doing a "pm_runtime_set_active()"
before "pm_runtime_enable()" was going to break other platforms.
More information about the linux-arm-kernel