[PATCH 01/15] ARM: clps711x: Load serial driver from boards

[Alexander Shiyan]

On Thu, 1 Nov 2012 12:27:31 +0000
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:

> BOn Thu, Nov 01, 2012 at 01:26:31PM +0400, Alexander Shiyan wrote:
> >  MACHINE_START(AUTCPU12, "autronix autcpu12")
> >  	/* Maintainer: Thomas Gleixner */
> >  	.atag_offset	= 0x20000,
> > -	.init_machine	= autcpu12_init,
> >  	.map_io		= autcpu12_map_io,
> > +	.init_machine	= autcpu12_init,
> >  	.init_irq	= clps711x_init_irq,
> > -	.timer		= &clps711x_timer,
> >  	.restart	= clps711x_restart,
> > +	.timer		= &clps711x_timer,
> >  MACHINE_END
> 
> NAK.  If you're going to sort them, arrange them in the same order as
> in the structure declaration in mach/arch.h.  That's the order in which
> the functions will be called.
> 
> IOW, changing the order of .timer to be after .restart is wrong, .restart
> should be the last.  .timer should be immediately before .init_machine.
> .init_irq should be immediately before .timer.

It's just sort by functionality and does not affect on operation.
Original sort I will return in the next patch after applying it.
Please comment on the rest of the patches in this series.
Thanks.

-- 
Alexander Shiyan <shc_work at mail.ru>