[PATCH 01/15] ARM: clps711x: Load serial driver from boards
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Nov 1 08:27:31 EDT 2012
BOn Thu, Nov 01, 2012 at 01:26:31PM +0400, Alexander Shiyan wrote:
> MACHINE_START(AUTCPU12, "autronix autcpu12")
> /* Maintainer: Thomas Gleixner */
> .atag_offset = 0x20000,
> - .init_machine = autcpu12_init,
> .map_io = autcpu12_map_io,
> + .init_machine = autcpu12_init,
> .init_irq = clps711x_init_irq,
> - .timer = &clps711x_timer,
> .restart = clps711x_restart,
> + .timer = &clps711x_timer,
NAK. If you're going to sort them, arrange them in the same order as
in the structure declaration in mach/arch.h. That's the order in which
the functions will be called.
IOW, changing the order of .timer to be after .restart is wrong, .restart
should be the last. .timer should be immediately before .init_machine.
.init_irq should be immediately before .timer.
More information about the linux-arm-kernel