[PATCH 4/7] ARM: mxs: Add SPI clock into clk framwork

Marek Vasut marex at denx.de
Tue Jun 26 08:16:11 EDT 2012


Dear Shawn Guo,

> On Sat, Jun 23, 2012 at 08:43:50PM +0200, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Chris Ball <cjb at laptop.org>
> > Cc: Detlev Zundel <dzu at denx.de>
> > CC: Dong Aisheng <b29396 at freescale.com>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > Cc: Grant Likely <grant.likely at secretlab.ca>
> > Cc: Linux ARM kernel <linux-arm-kernel at lists.infradead.org>
> > Cc: Rob Herring <rob.herring at calxeda.com>
> > CC: Shawn Guo <shawn.guo at linaro.org>
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Wolfgang Denk <wd at denx.de>
> > ---
> > 
> >  drivers/clk/mxs/clk-imx28.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> > index 003b0f3..d22b926 100644
> > --- a/drivers/clk/mxs/clk-imx28.c
> > +++ b/drivers/clk/mxs/clk-imx28.c
> > @@ -149,21 +149,25 @@ static struct clk_lookup xbus_lookups[] __initdata
> > = {
> > 
> >  static struct clk_lookup ssp0_lookups[] __initdata = {
> >  
> >  	{ .dev_id = "imx28-mmc.0", },
> > 
> > +	{ .dev_id = "imx28-spi.0", },
> > 
> >  	{ .dev_id = "80010000.ssp", },
> >  
> >  };
> >  
> >  static struct clk_lookup ssp1_lookups[] __initdata = {
> >  
> >  	{ .dev_id = "imx28-mmc.1", },
> > 
> > +	{ .dev_id = "imx28-spi.1", },
> > 
> >  	{ .dev_id = "80012000.ssp", },
> >  
> >  };
> >  
> >  static struct clk_lookup ssp2_lookups[] __initdata = {
> >  
> >  	{ .dev_id = "imx28-mmc.2", },
> > 
> > +	{ .dev_id = "imx28-spi.2", },
> > 
> >  	{ .dev_id = "80014000.ssp", },
> >  
> >  };
> >  
> >  static struct clk_lookup ssp3_lookups[] __initdata = {
> >  
> >  	{ .dev_id = "imx28-mmc.3", },
> > 
> > +	{ .dev_id = "imx28-spi.3", },
> > 
> >  	{ .dev_id = "80016000.ssp", },
> >  
> >  };
> 
> These changes should not be needed, as the driver will only be probed
> from device tree.

So why are those imx28-mmc there ? Shall these not be removed then ?

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list