[PATCH] ARM: mx28: Add LCD pinmux

[Marek Vasut]

Dear Fabio Estevam,

> Hi Marek,
> 
> On Sat, Jun 23, 2012 at 3:45 PM, Marek Vasut <marex at denx.de> wrote:
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Detlev Zundel <dzu at denx.de>
> > CC: Dong Aisheng <b29396 at freescale.com>
> > CC: Fabio Estevam <fabio.estevam at freescale.com>
> > Cc: Linux ARM kernel <linux-arm-kernel at lists.infradead.org>
> > CC: Shawn Guo <shawn.guo at linaro.org>
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Wolfgang Denk <wd at denx.de>
> > ---
> >  arch/arm/boot/dts/imx28.dtsi |   45
> > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45
> > insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 464303c..ab29cbe 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -221,6 +221,51 @@
> >                                        fsl,pull-up = <0>;
> >                                };
> > 
> > +                               lcd_data_pins_8bpp_a: lcd at 0 {
> 
> Please remove the "bpp" from all the names.
> 
> bpp is usually used for the pixel depth in a framebuffer, and what you
> are describing here is how many bits are physically connected into the
> LCD interface.

But the BPP should corelate with the number of connected data pins. Or do you 
have any counter-argument? And besides, it's much easier to understand like 
that.

> Regards,
> 
> Fabio Estevam

Best regards,
Marek Vasut