[PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

Jon Hunter jon-hunter at ti.com
Wed Jun 13 11:44:30 EDT 2012

Hi Afzal,

On 06/13/2012 02:37 AM, Mohammed, Afzal wrote:
> Hi Jon,
> On Tue, Jun 12, 2012 at 23:45:36, Hunter, Jon wrote:
>> So, GPMC_WAITPIN_IDX0 = GPMC_WAITPIN_0 - 1, assuming that you want idx =
>> 0 and not 1. Or you could change you shift value too. I was just
>> highlighting that they are not equal but one set of definitions could be
>> used.
> In that case we would be directly depending on user flag whose value may
> or may not change and I don't think it is good to directly depend on it
> for waitpin # calculation.

You are already dependent on it. In other words, you are going to set
the waitpin # according to these flags in the first place. I don't see
the difference.

Bottom line is that we don't need to have multiple definitions for the
same thing.


More information about the linux-arm-kernel mailing list