[PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

Mohammed, Afzal afzal at ti.com
Wed Jun 13 03:37:56 EDT 2012


Hi Jon,

On Tue, Jun 12, 2012 at 23:45:36, Hunter, Jon wrote:

> GPMC_WAITPIN_IDX0 = 0
> GPMC_WAITPIN_0 = 1
> 
> So, GPMC_WAITPIN_IDX0 = GPMC_WAITPIN_0 - 1, assuming that you want idx =
> 0 and not 1. Or you could change you shift value too. I was just
> highlighting that they are not equal but one set of definitions could be
> used.

In that case we would be directly depending on user flag whose value may
or may not change and I don't think it is good to directly depend on it
for waitpin # calculation.

Regards
Afzal



More information about the linux-arm-kernel mailing list