[PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

Tony Lindgren tony at atomide.com
Wed Jun 13 08:07:17 EDT 2012


* Jon Hunter <jon-hunter at ti.com> [120612 11:01]:
> 
> On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
> > Hi Jon,
> > 
> > On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote:
> > 
> >>> +	gpmc_revision = (l >> 4) & 0xf;
> >>
> >> Why are you only storing the major part of the rev? Why not keep both parts?
> > 
> > Does having minor revision add any value ?, at least as of now,
> > I do not see any.
> 
> May be not but it does not hurt either.

Yeah might as well show the full revision.

Tony



More information about the linux-arm-kernel mailing list