[PATCH V2 03/10] ARM: OMAP4: Re-map the CTIs IRQs from MPU to DEBUGSS

Pandita, Vikram vikram.pandita at ti.com
Wed Jun 13 02:13:28 EDT 2012


On Tue, Jun 12, 2012 at 11:07 PM, Pandita, Vikram <vikram.pandita at ti.com> wrote:
> On Thu, Jun 7, 2012 at 2:22 PM, Jon Hunter <jon-hunter at ti.com> wrote:
>> In order to use the CTI interrupts inconjunction with the DEBUGSS we need to
>> re-map the CTI IRQs to the DEBUGSS HWMOD. The purpose for doing this is so we
>> can create a PMU device based upon the DEBUGSS HWMOD and use the CTI interrupts
>> for routing ARM PMU events for OMAP4430 devices.
>>
>> This is based upon Benoit Cousson's patch [1].
>>
>> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/073319.html
>>
>> Cc: Ming Lei <ming.lei at canonical.com>
>> Cc: Will Deacon <will.deacon at arm.com>
>> Cc: Benoit Cousson <b-cousson at ti.com>
>> Cc: Paul Walmsley <paul at pwsan.com>
>> Cc: Kevin Hilman <khilman at ti.com>
>>
>> Reviewed-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
>> Signed-off-by: Jon Hunter <jon-hunter at ti.com>
>> ---
>>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index 950454a..faf5a6d 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -482,10 +482,17 @@ static struct omap_hwmod_class omap44xx_debugss_hwmod_class = {
>>  };
>>
>>  /* debugss */
>> +static struct omap_hwmod_irq_info omap44xx_debugss_irqs[] = {
>> +       { .name = "cti0", .irq = 1 + OMAP44XX_IRQ_GIC_START },
>> +       { .name = "cti1", .irq = 2 + OMAP44XX_IRQ_GIC_START },
>
> Data manual assigns cit0 == MA_IRQ_1 and cti1 == MA_IRQ_2
> Why do you add 32 base GIC_START ?

Looks we do the same for pl310:
{ .name = "pl310", .irq = 0 + OMAP44XX_IRQ_GIC_START },

so u can ignore my comment .. excuse the noise...

>
>> +       { .irq = -1 }
>> +};
>> +
>>  static struct omap_hwmod omap44xx_debugss_hwmod = {
>>        .name           = "debugss",
>>        .class          = &omap44xx_debugss_hwmod_class,
>>        .clkdm_name     = "emu_sys_clkdm",
>> +       .mpu_irqs       = omap44xx_debugss_irqs,
>>        .main_clk       = "trace_clk_div_ck",
>>        .prcm = {
>>                .omap4 = {
>> @@ -2447,8 +2454,6 @@ static struct omap_hwmod_class omap44xx_mpu_hwmod_class = {
>>  /* mpu */
>>  static struct omap_hwmod_irq_info omap44xx_mpu_irqs[] = {
>>        { .name = "pl310", .irq = 0 + OMAP44XX_IRQ_GIC_START },
>> -       { .name = "cti0", .irq = 1 + OMAP44XX_IRQ_GIC_START },
>> -       { .name = "cti1", .irq = 2 + OMAP44XX_IRQ_GIC_START },
>>        { .irq = -1 }
>>  };
>>
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list