[PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

[Mohammed, Afzal]

Hi Jon,

On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote:

> > +	gpmc_revision = (l >> 4) & 0xf;
> 
> Why are you only storing the major part of the rev? Why not keep both parts?

Does having minor revision add any value ?, at least as of now,
I do not see any.

> 
> > +	dev_info(gpmc_dev, "GPMC revision %d.%d\n", gpmc_revision, l & 0x0f);
> 
> Nit-pick, please add a mask and shift definition for the revision
> register major and minor fields and use these above.

Yes, right

Regards
Afzal