[PATCH v3 02/10] pwm: Allow chips to support multiple PWMs.
thierry.reding at avionic-design.de
Thu Feb 23 11:04:20 EST 2012
* Arnd Bergmann wrote:
> On Thursday 23 February 2012, Thierry Reding wrote:
> > > Is this only used for the device tree functions? If so, I would recommend
> > > making it less generic and always search for a device node.
> > It is currently only used to look up a struct pwm_chip for a given struct
> > device_node, yes. But I can see other uses for this. For instance this could
> > be useful if we ever want to provide an alternative way of requesting a PWM
> > on a per-chip basis.
> Nah, just keep it simple for now. If we need it later, we can still
> add something like this back, but for now it's just a source of
> confusion and possible bugs.
> > I was again basically looking at gpiolib for inspiration (maybe I should stop
> > doing that :-). Maybe gpiolib should be reworked to use seq_file's iterator
> > interface as well? Just in case anybody else turns to gpiolib for
> > inspiration.
> Good idea. Would you be able to send a patch for that, too? I would guess
> converting both at the same time would be easier for you than splitting
> the work between two people.
I'll take a shot at it. It may take some time, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the linux-arm-kernel