[PATCH] arm/io.h: add macros to read/write big/little endian register

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Feb 23 06:38:01 EST 2012


On Thu, Feb 23, 2012 at 05:04:28PM +0530, Pratyush Anand wrote:
> On 2/23/2012 4:49 PM, Russell King - ARM Linux wrote:
>> On Thu, Feb 23, 2012 at 04:23:11PM +0530, Viresh Kumar wrote:
>>> On 2/23/2012 3:23 PM, Russell King - ARM Linux wrote:
>>>> 1. Using the PCI/ISA IO macros for non-PCI/ISA IO purposes is silly
>>>
>>> We mistakenly placed it outside #ifdef __io, #endif
>>> Sorry, i am still missing your point.
>>
>> inb() et.al. are for PCI/ISA IO, not for general platform MMIO.
>>
>
> Ok.. So, will it be fine if we keep it outside #ifdef __io and do not  
> use __io macro in their implementation?

No, I refuse to add another set of accessors to ARMs io.h.  They're private
to PPC - it even says so in their header file.  They should not have leaked
out of PPC.

The fact that 73 drivers in the kernel source use their accessors is their
problem to solve.



More information about the linux-arm-kernel mailing list