[PATCH] arm/io.h: add macros to read/write big/little endian register
Pratyush Anand
pratyush.anand at st.com
Thu Feb 23 06:34:28 EST 2012
On 2/23/2012 4:49 PM, Russell King - ARM Linux wrote:
> On Thu, Feb 23, 2012 at 04:23:11PM +0530, Viresh Kumar wrote:
>> On 2/23/2012 3:23 PM, Russell King - ARM Linux wrote:
>>> 1. Using the PCI/ISA IO macros for non-PCI/ISA IO purposes is silly
>>
>> We mistakenly placed it outside #ifdef __io, #endif
>> Sorry, i am still missing your point.
>
> inb() et.al. are for PCI/ISA IO, not for general platform MMIO.
>
Ok.. So, will it be fine if we keep it outside #ifdef __io and do not
use __io macro in their implementation?
>>> 2. We should have readb_be() etc instead.
>>
>> Actually, existing drivers are using out_be32(), etc in their implementation.
>> What do you suggest in order to use these drivers for SPEAr/ARM.
>
> Which drivers?
> .
>
We have used these macros in dwc_otg driver, which is still to be added
in the main line , but is under discussion.
http://comments.gmane.org/gmane.linux.usb.general/53348
However, I do see that these macros have been used in several mainline
driver also, e.g. drivers/usb/gadget/fsl_qe_udc.c.
Regards
Pratyush
More information about the linux-arm-kernel
mailing list