[PATCH 2/2] iommu/omap: fix NULL pointer dereference

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Feb 22 04:17:52 EST 2012


On Wed, Feb 22, 2012 at 11:10:38AM +0200, Ohad Ben-Cohen wrote:
> On Wed, Feb 22, 2012 at 10:56 AM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > There's something else which needs fixing here - the return code.  If
> > omap_find_iovm_area() returns an error code that needs propagating.
> > Otherwise it might as well just return NULL for all errors.
> 
> Seems like it does just return NULL for all errors, so a cleaner fix
> can probably just be s/IS_ERR(area)/!area/.
> 
> I'll submit it, but Joerg, if you feel this is becoming a "cleanup",
> feel free to take the first version.

That sounds more like a bug fix than a cleanup to me.



More information about the linux-arm-kernel mailing list