[PATCH 2/2] iommu/omap: fix NULL pointer dereference

Ohad Ben-Cohen ohad at wizery.com
Wed Feb 22 04:10:38 EST 2012


On Wed, Feb 22, 2012 at 10:56 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> There's something else which needs fixing here - the return code.  If
> omap_find_iovm_area() returns an error code that needs propagating.
> Otherwise it might as well just return NULL for all errors.

Seems like it does just return NULL for all errors, so a cleaner fix
can probably just be s/IS_ERR(area)/!area/.

I'll submit it, but Joerg, if you feel this is becoming a "cleanup",
feel free to take the first version.

Thanks,
Ohad.



More information about the linux-arm-kernel mailing list