[PATCH 03/10] serial: atmel: add explict mach/gpio.h include

Rob Herring robherring2 at gmail.com
Thu Aug 30 23:00:28 EDT 2012


On 08/29/2012 06:37 PM, Russell King - ARM Linux wrote:
> On Wed, Aug 29, 2012 at 05:31:29PM -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring at calxeda.com>
>>
>> In preparation to remove implicit inclusion of mach/gpio.h, add explicit
>> include of mach/gpio.h.
> 
> Definitely NAK.
> 
> What is in the Atmel mach/gpio.h has hardly anything to do with the
> gpio subsystem (it's more a private gpio implementation).  It should
> be renamed as such to make it clear (and so it doesn't trigger my
> sanity filtering.)

Jean-Christophe, Does your gpio clean-up address this?

Rob




More information about the linux-arm-kernel mailing list