[PATCH 03/10] serial: atmel: add explict mach/gpio.h include

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Aug 29 19:37:05 EDT 2012


On Wed, Aug 29, 2012 at 05:31:29PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> In preparation to remove implicit inclusion of mach/gpio.h, add explicit
> include of mach/gpio.h.

Definitely NAK.

What is in the Atmel mach/gpio.h has hardly anything to do with the
gpio subsystem (it's more a private gpio implementation).  It should
be renamed as such to make it clear (and so it doesn't trigger my
sanity filtering.)



More information about the linux-arm-kernel mailing list