[PATCH] clk: provide prepare/unprepare functions

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Sep 27 04:26:05 EDT 2011

On Thu, Sep 22, 2011 at 10:39:14AM -0700, Saravana Kannan wrote:
>>   /**
>> + * clk_prepare - prepare a clock source
>> + * @clk: clock source
>> + *
>> + * This prepares the clock source for use.
> Do you want to add a "May NOT be called from atomic context"? Yeah, the  
> stub makes it obvious, but I think it would be consistent to add the  
> comment in. No strong opinion though.

The might_sleep() is sufficient to enforce that, but adding the comment
for when the helper goes away would be a good idea.

> Not sure if you care, but LGTM/Ack.


More information about the linux-arm-kernel mailing list