[RFC PATCH 01/14] ARM: GIC: Add global gic_handle_irq() function
Marc Zyngier
marc.zyngier at arm.com
Mon Sep 26 06:40:49 EDT 2011
On 23/09/11 21:18, Russell King - ARM Linux wrote:
> On Fri, Sep 23, 2011 at 05:51:19PM +0100, Marc Zyngier wrote:
>> + if (irqnr < 16) {
>> + writel_relaxed(irqstat, gic_cpu_base_addr + GIC_CPU_EOI);
>> +#ifdef CONFIG_SMP
>> + do_IPI(irqnr, regs);
>> +#endif
>
> This doesn't work. do_IPI is marked as an entry function, and so expects
> to be called with the precondition that the pt_regs are stored immediately
> above its stack frame, without another function's stack frame in the way.
>
Good point. I'll add a handle_IPI() function, modeled after handle_IRQ().
Thanks for pointing this out.
M.
--
Jazz is not dead. It just smells funny...
More information about the linux-arm-kernel
mailing list