[PATCH v2 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2
Jon Medhurst (Tixy)
jon.medhurst at linaro.org
Fri Sep 9 10:05:18 EDT 2011
On Fri, 2011-09-09 at 09:21 -0400, Nicolas Pitre wrote:
> On Fri, 9 Sep 2011, Jon Medhurst (Tixy) wrote:
>
> > On Thu, 2011-09-08 at 11:49 -0700, Eric Miao wrote:
> > > So the problem is really when compiling this file with existing toolchain,
> > > it's downgrading to v5 compatible mode, and the instruction below
> > >
> > > sub pc, lr, r1, lsr #32
> > >
> > > wouldn't be encoded when building a THUMB2 kernel. Considering the
> > > r1, lsr #32 is actually to create an explicit data dependency of the previous
> > > co-processor instruction, would it be one option to rewrite this as something
> > > like:
> > >
> > > mov r1, r1
> > > mov pc, lr
> >
> > That doesn't include a data dependency of PC on R1, so it's possible for
> > MOV PC, LR and subsequent instructions to be executed before MOV R1, R1
> > has completed. We would want...
> >
> > add lr, lr, r1, lsr #32
> > mov pc, lr
>
> But isn't the first insn unavailable with Thumb2?
It is available in Thumb2.
> Maybe something like:
>
> sub r1, r1, r1
> add pc, lr, r1
That's not allowed in Thumb2. ;-)
There aren't many instruction forms which are allowed to set PC.
--
Tixy
More information about the linux-arm-kernel
mailing list