[PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Oct 28 08:42:00 EDT 2011


On Fri, Oct 28, 2011 at 02:15:00PM +0200, Mike Frysinger wrote:
> On Thu, Oct 27, 2011 at 15:11, Russell King - ARM Linux wrote:
> > This is extremely dangerous.  Consider for example this code
> > (see ARM mach-davinci's gpio.h):
> 
> it's interesting you highlight davinci.  if i'm reading things
> correctly, the current davinci code is broken today and my v2 proposed
> patch actually fixes it.

That looks like an error in patch 5f3fcf9649dbb010ccac41259d04147775ec8fc2
(ARM: 7040/1: mach-davinci: break out GPIO driver specifics) which does
this:

-#define __ARM_GPIOLIB_COMPLEX

Linus, can you send a fix?



More information about the linux-arm-kernel mailing list