[PATCH v2 3/5] regulator: helper routine to extract regulator_init_data
rnayak at ti.com
Mon Oct 24 04:53:50 EDT 2011
On Monday 24 October 2011 01:47 PM, Grant Likely wrote:
> On Mon, Oct 24, 2011 at 11:32:19AM +0530, Rajendra Nayak wrote:
>> On Friday 21 October 2011 05:28 PM, Shawn Guo wrote:
>>> On Fri, Oct 21, 2011 at 02:11:55PM +0530, Rajendra Nayak wrote:
>>>>> + /* find device_node and attach it */
>>>>> + rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name);
How about the driver passing the of_node to be associated with the
regulator, as part of regulator_desc, to the regulator core,
instead of this complete DT search and the restriction of having
to match DT node names with names in regulator_desc.
>>>> so would this do a complete dt search for every regulator?
>>> Yes, with the first param being NULL, tthe entire device tree will be
>>>> we would also need the driver names and dt names to match for this to
>>>> work, right?
>>> Driver name does not matter. The key for this search to work is having
>>> regulator's name (regulator_desc->name) match device tree node's name,
>>> case ignored.
>> Mark, whats your take on this? I am somehow not quite sure if we should
>> have this limitation put in to match DT node names with whats in the
>> driver structs (regulator_desc).
> This looks wrong to me. Matching based on node /name/, particularly
> when searching the entire tree, will cause problems.
More information about the linux-arm-kernel